Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#409 User now being passed to DyRepos #528

Merged
merged 5 commits into from Mar 20, 2015
Merged

#409 User now being passed to DyRepos #528

merged 5 commits into from Mar 20, 2015

Conversation

carlosmiranda
Copy link
Contributor

No description provided.

@carlosmiranda carlosmiranda mentioned this pull request Mar 19, 2015
Closed
@davvd
Copy link
Collaborator

davvd commented Mar 19, 2015

Let me find a reviewer for this pull request, thanks for submitting it

@davvd
Copy link
Collaborator

davvd commented Mar 19, 2015

@krzyk review this one, please

krzyk
krzyk reviewed Mar 19, 2015
View reviewed changes
src/test/java/com/thindeck/dynamo/DyReposTest.java
}

/**
* DyRepos can return the specified user if the user was not specified.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment is not correct, it should be DyRepos can return the specified user., without the rest.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks! Silly mistake...

@krzyk
Copy link
Contributor

krzyk commented Mar 19, 2015

@carlosmiranda few javadoc comments from me

@carlosmiranda
Copy link
Contributor Author

@krzyk Thanks for the review, I pushed new commits.

@krzyk
Copy link
Contributor

krzyk commented Mar 19, 2015

@rultor merge pls

@rultor
Copy link
Collaborator

rultor commented Mar 19, 2015

@rultor merge pls

@krzyk Thanks for your request. @carlosmiranda Please confirm this.

@carlosmiranda
Copy link
Contributor Author

@yegor256 Can you confirm?

@yegor256
Copy link
Owner

@rultor merge pls

@rultor
Copy link
Collaborator

rultor commented Mar 19, 2015

@rultor merge pls

@yegor256 Thanks for your request. @carlosmiranda Please confirm this.

@carlosmiranda
Copy link
Contributor Author

@rultor merge please

@rultor
Copy link
Collaborator

rultor commented Mar 19, 2015

@rultor merge please

@carlosmiranda OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit b03d157 into yegor256:master Mar 20, 2015
@rultor
Copy link
Collaborator

rultor commented Mar 20, 2015

@rultor merge please

@carlosmiranda Done! FYI, the full log is here (took me 22min)

@davvd
Copy link
Collaborator

davvd commented Mar 23, 2015

@krzyk Thanks for your contribution, 17 mins was added to your account, payment ID is 54081598; review comments (c=2) added as a bonus; added +17 to your rating, now it is equal to +5098

@davvd
Copy link
Collaborator

davvd commented Mar 23, 2015

@rultor deploy

@rultor
Copy link
Collaborator

rultor commented Mar 23, 2015

@rultor deploy

@davvd OK, I'll try to deploy now. You can check the progress here

@rultor
Copy link
Collaborator

rultor commented Mar 23, 2015

@rultor deploy

@davvd Done! FYI, the full log is here (took me 11min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
@krzyk
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@carlosmiranda @davvd @krzyk @rultor @yegor256