#409 User now being passed to DyRepos

src/main/java/com/thindeck/MnBase.java

@@ -138,6 +138,10 @@ public Repo add(final String name) {
         public Iterable<Repo> iterate() {
             return Collections.<Repo>singleton(new MnBase.FakeRepo());
         }
+        @Override
+        public User user() {
+            throw new UnsupportedOperationException("#user()");
+        }
     }
 
     /**

src/main/java/com/thindeck/api/Repo.java

@@ -43,6 +43,9 @@
  * @author Yegor Bugayenko (yegor@tpc2.com)
  * @version $Id$
  * @since 0.1
+ * @todo #409:30min Let's add a new method User user(). It should return the
+ *  User whom the Repo is associated to. Let's also add implementations in the
+ *  classes that implement this interface.
  */
 @Immutable
 public interface Repo {

src/main/java/com/thindeck/api/Repos.java

@@ -74,4 +74,11 @@ public interface Repos {
     @NotNull(message = "iterable of repos can't be null")
     Iterable<Repo> iterate();
 
+    /**
+     * The owner of this.
+     * @return Owner of the repos.
+     */
+    @NotNull(message = "user of repos can't be null")
+    User user();
+
 }

src/main/java/com/thindeck/api/User.java

@@ -31,6 +31,7 @@
 
 import com.jcabi.aspects.Immutable;
 import com.jcabi.urn.URN;
+import java.net.URISyntaxException;
 import javax.validation.constraints.NotNull;
 
 /**
@@ -42,6 +43,27 @@
  */
 @Immutable
 public interface User {
+    /**
+     * Default User.
+     */
+    User DEFAULT = new User() {
+        @Override
+        public URN urn() {
+            try {
+                return new URN("urn:thindeck:DEFAULT");
+            } catch (final URISyntaxException ex) {
+                throw new IllegalStateException(ex);
+            }
+        }
+        @Override
+        public Repos repos() {
+            throw new UnsupportedOperationException();
+        }
+        @Override
+        public Usage usage() {
+            throw new UnsupportedOperationException();
+        }
+    };
 
     /**
      * URN.

src/main/java/com/thindeck/api/mock/MkRepos.java

@@ -32,6 +32,7 @@
 import com.jcabi.aspects.Immutable;
 import com.thindeck.api.Repo;
 import com.thindeck.api.Repos;
+import com.thindeck.api.User;
 import java.util.Collections;
 import lombok.EqualsAndHashCode;
 import lombok.ToString;
@@ -62,4 +63,9 @@ public Repo add(final String name) {
     public Iterable<Repo> iterate() {
         return Collections.<Repo>singleton(new MkRepo());
     }
+
+    @Override
+    public User user() {
+        return new MkUser();
+    }
 }

src/main/java/com/thindeck/dynamo/DyRepos.java

@@ -39,6 +39,7 @@
 import com.jcabi.dynamo.Region;
 import com.thindeck.api.Repo;
 import com.thindeck.api.Repos;
+import com.thindeck.api.User;
 import java.io.IOException;
 import java.util.Iterator;
 import lombok.EqualsAndHashCode;
@@ -58,12 +59,27 @@ public final class DyRepos implements Repos {
      */
     private final transient Region region;
 
+    /**
+     * Owner of these.
+     */
+    private final transient User owner;
+
     /**
      * Constructor.
      * @param rgn Region
      */
     public DyRepos(final Region rgn) {
+        this(rgn, User.DEFAULT);
+    }
+
+    /**
+     * Constructor.
+     * @param rgn Region
+     * @param usr The user of the Repos
+     */
+    public DyRepos(final Region rgn, final User usr) {
         this.region = rgn;
+        this.owner = usr;
     }
 
     @Override
@@ -89,6 +105,10 @@ public Repo add(final String name) {
         }
     }
 
+    //@todo #409:30min We should include the User as a filter to the repos that
+    // will be fetched. If the Default user is specified, we should return all
+    // repos. Otherwise, only the repos of that specific user should be
+    // contained in the Iterable.
     @Override
     public Iterable<Repo> iterate() {
         return Iterables.transform(
@@ -108,6 +128,11 @@ public Repo apply(final Item input) {
         );
     }
 
+    @Override
+    public User user() {
+        return this.owner;
+    }
+
     /**
      * Get iterator over repos with the name specified.
      * If this repo exists, the iterator's set will contain 1 element.

src/main/java/com/thindeck/dynamo/DyUser.java

@@ -44,13 +44,6 @@
  *
  * @author Krzysztof Krason (Krzysztof.Krason@gmail.com)
  * @version $Id$
- * @todo #374:30min At the moment, the repos() method returns all Repos associated
- *  with the Dynamo region, and this is definitely incorrect. I think we need to
- *  refactor DyRepos in order to include a user criteria (probably URN) in its
- *  constructor, and have DyUser pass it so that it will only return the
- *  associated criteria. I'm not completely sure about this design, feel free to
- *  implement something else if you think it's wrong. The intuition behind it is
- *  that we should only get the repos associated with the current user.
  */
 @EqualsAndHashCode
 @ToString
@@ -90,7 +83,7 @@ public URN urn() {
 
     @Override
     public Repos repos() {
-        return new DyRepos(this.item.frame().table().region());
+        return new DyRepos(this.item.frame().table().region(), this);
     }
 
     @Override

src/test/java/com/thindeck/dynamo/DyReposTest.java

@@ -36,11 +36,13 @@
 import com.jcabi.dynamo.mock.MkRegion;
 import com.thindeck.api.Repo;
 import com.thindeck.api.Repos;
+import com.thindeck.api.User;
 import java.io.IOException;
 import java.util.Iterator;
 import org.hamcrest.MatcherAssert;
 import org.hamcrest.Matchers;
 import org.junit.Test;
+import org.mockito.Mockito;
 
 /**
  * Tests for {@link DyRepos}.
@@ -127,6 +129,31 @@ public void iteratesOverMultipleRepos() throws IOException {
         MatcherAssert.assertThat(repos.hasNext(), Matchers.is(false));
     }
 
+    /**
+     * DyRepos can return the default user if the user was not specified.
+     * @throws Exception If something goes wrong.
+     */
+    @Test
+    public void returnsDefaultUser() throws Exception {
+        MatcherAssert.assertThat(
+            new DyRepos(Mockito.mock(Region.class)).user(),
+            Matchers.is(User.DEFAULT)
+        );
+    }
+
+    /**
+     * DyRepos can return the specified user if the user was not specified.
+     * @throws Exception If something goes wrong.
+     */
+    @Test
+    public void returnsSpecifiedUser() throws Exception {
+        final User user = Mockito.mock(User.class);
+        MatcherAssert.assertThat(
+            new DyRepos(Mockito.mock(Region.class), user).user(),
+            Matchers.is(user)
+        );
+    }
+
     /**
      * Create region with repos.
      * @param names Names of the repos.

src/test/java/com/thindeck/dynamo/DyUserTest.java

@@ -99,6 +99,32 @@ public void canGetRepos() throws Exception {
         );
     }
 
+    /**
+     * DyUser can get itself from the Repos that it returns.
+     * @throws Exception If something goes wrong
+     */
+    @Test
+    public void getsReposForItself() throws Exception {
+        final Region region = new MkRegion(
+            new H2Data().with(
+                    DyRepo.TBL,
+                new String[] {DyRepo.ATTR_NAME},
+                new String[] {DyRepo.ATTR_UPDATED}
+            )
+        );
+        final Table table = region.table(DyRepo.TBL);
+        table.put(
+            new Attributes()
+                .with(DyRepo.ATTR_NAME, "test-user-repo")
+                .with(DyRepo.ATTR_UPDATED, System.currentTimeMillis())
+        );
+        final User user = new DyUser(table.frame().iterator().next());
+        MatcherAssert.assertThat(
+            user.repos().user(),
+            Matchers.is(user)
+        );
+    }
+
     /**
      * DyUser can return usage info.
      * @throws Exception If something goes wrong.