Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

English misses keys! #34

Closed
rampa3 opened this issue Oct 4, 2023 · 4 comments
Closed

English misses keys! #34

rampa3 opened this issue Oct 4, 2023 · 4 comments
Assignees
@ProbablePrime
Labels
RequiresAppWork This issue requires app work and needs to be handled by the Development Team.

Comments

@rampa3
Copy link
Contributor

rampa3 commented Oct 4, 2023

Original en.json is missing the key Inventory.CreateDirectory.
@rampa3 rampa3 changed the title English misses key Inventory.CreateDirectory English misses keys! Oct 4, 2023
@rampa3
Copy link
Contributor Author

rampa3 commented Oct 4, 2023

Also I found out there is no key for the Get URL button - might be hardcoded right now, since it has a label while there are no keys for it anywhere. If I find any more missing keys, they will be added here.

@ProbablePrime ProbablePrime self-assigned this Oct 5, 2023
@ProbablePrime
Copy link
Member

Your second issue has a fix submitted, I'll update locale soon.

@ProbablePrime ProbablePrime added the RequiresAppWork This issue requires app work and needs to be handled by the Development Team. label Oct 5, 2023
@ProbablePrime
Copy link
Member

#51 has the url string

@brodokk
Copy link
Contributor

brodokk commented Oct 5, 2023

I should have added it here, there is a fix for the first one here #49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ProbablePrime ProbablePrime

Labels
RequiresAppWork This issue requires app work and needs to be handled by the Development Team.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ProbablePrime @rampa3 @brodokk