Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GlobalDelegate and DelegateProxy components make world unjoinable #14

Closed
lxw404 opened this issue Oct 13, 2023 · 4 comments
Closed

GlobalDelegate and DelegateProxy components make world unjoinable #14

lxw404 opened this issue Oct 13, 2023 · 4 comments
Assignees
Labels
bug Something isn't working as intended.

Comments

@lxw404
Copy link

lxw404 commented Oct 13, 2023

Describe the bug?

If you attach a GlobalDelegate<T> or DelegateProxy<T> component to any slot in a world, it will immediately disconnect all users but the host, and make the world unjoinable forever afterwards.

To Reproduce

  • Create an empty slot.
  • Attach either the component GlobalDelegate<T> or DelegateProxy<T>.

Expected behavior

These components should probably not crash people out of the world.

Screenshots

No response

Resonite Version Number

2023.10.13.743

What Platforms does this occur on?

Windows

What headset if any do you use?

No response

Log Files

No response

Additional Context

No response

Reporters

LuxKitty, Nytra

@lxw404 lxw404 added the bug Something isn't working as intended. label Oct 13, 2023
@Nytra
Copy link

Nytra commented Oct 14, 2023

I think it is specifically when you make these components with an invalid type as T, for example making GlobalDelegate<Slot> or DelegateProxy<Slot> causes an exception

@shiftyscales
Copy link
Collaborator

Please follow the best practices for reports on this repo and fill all fields as completely as you can including submission of log files from all participants, @lxw404 @Nytra.

@lxw404
Copy link
Author

lxw404 commented Oct 18, 2023

Here are two separate sets of logs, they are labeled by the component that was added as well as whether it was the Host of the session or the Guest. In both instances, the guest joins the host in a completely empty world, then the offending component is added and they get disconnected and can never rejoin.

DelegateProxy - Host - 2023.10.18.449 - 2023-10-18 07_57_11.log
DelegateProxy - Guest -2023.10.18.449-_2023-10-18_12_56_15.log

GlobalDelegate - Host - 2023.10.18.449 - 2023-10-18 08_01_34.log
GlobalDelegate - Guest -2023.10.18.449-_2023-10-18_12_59_34.log

@shiftyscales shiftyscales removed their assignment Jan 29, 2024
@RyuviTheViali RyuviTheViali self-assigned this Jun 28, 2024
@Frooxius
Copy link
Member

Merged fix in 2024.7.15.1359, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as intended.
Projects
None yet
Development

No branches or pull requests

5 participants