Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile has yelp dependencies #6

Closed
bxm156 opened this issue Feb 16, 2017 · 4 comments
Closed

Makefile has yelp dependencies #6

bxm156 opened this issue Feb 16, 2017 · 4 comments

Comments

@bxm156
Copy link
Member

bxm156 commented Feb 16, 2017

Certain commands in the Makefile are yelp-specific. We may want to consider making things more generic in the future.

Specifically: pip-faster, venv-update, pip-custom platform

@kentwills
Copy link
Contributor

@bxm156 Is this a problem? All deps are required in the requirements-bootrap.txt and it allows for an easy idempotent venv setup.

@bxm156
Copy link
Member Author

bxm156 commented Feb 16, 2017

Nope, not a problem, I just wanted to note it in a ticket. bin/* is not something thats automatically updated. Its copy/pasted around. Its up to us as developers to ensure its updated.

@asottile
Copy link
Contributor

While these tools are things that are used at yelp, there's nothing yelp-specific about them:

@bxm156
Copy link
Member Author

bxm156 commented Feb 21, 2017

Cool, good to know!

@bxm156 bxm156 closed this as completed Feb 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants