Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate recipes as features into the generator #592

Closed
silvenon opened this issue Nov 6, 2016 · 5 comments
Closed

Integrate recipes as features into the generator #592

silvenon opened this issue Nov 6, 2016 · 5 comments
Labels

Comments

@silvenon
Copy link
Member

silvenon commented Nov 6, 2016

The idea of recipes was to avoid a lot of maintenance, but over time I got a feeling that they actually might require more maintenance, because:

  • they can easily become out-of-date, since I can't regularly check every snippet of every recipe all the time
  • we can't write tests for them
  • if there's a problem with a recipe, I usually have to follow every step myself to check what isn't working well, if it was a feature I could just scaffold my project
  • writing new recipes takes a lot of time, I would argue that it takes longer than implementing them as a feature because we have to spend time writing a tutorial

I didn't have experience with this, so I'm not sure if this is a good idea. Do you guys have any thoughts?

@sindresorhus @kevva @eddiemonge @neilhem

@eddiemonge
Copy link
Member

It would be better if recipes were community maintained

@silvenon
Copy link
Member Author

silvenon commented Nov 6, 2016

@eddiemonge what do you mean?

@eddiemonge
Copy link
Member

meaning we didnt have to do them. adding them as features to the generator means our maintenance level goes way up having to support all these different combinations

@neilhem
Copy link
Collaborator

neilhem commented Nov 7, 2016

Yeah, adding as a feature in generator significantly increases app logic. How about maintaining separate generators which have the same base, but support some functionality from recipe as difference?

@silvenon
Copy link
Member Author

silvenon commented Nov 8, 2016

It still sucks to have outdated docs lying around. But yeah, I see how silly my idea was, especially because some recipes can't be fully integrated, like the CoffeeScript one which involves changing tests.

Thanks for the talk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants