This repository has been archived by the owner on Apr 20, 2018. It is now read-only.
fix(jscs): update rules #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephanebachelier
force-pushed
the
jscs-update
branch
from
dea63e8
to
5ad3d10
Compare
stephanebachelier
changed the title
|
Do not merge as I need to update when the grunt preset will be defined for jscs. |
@stephanebachelier Any update in here? For me this LGTM as it is. |
|
@arthurvr I need to review my PR as it was done before grunt preset where validated on jscs. Will take some time tomorrow. |
stephanebachelier
changed the title
stephanebachelier
changed the title
stephanebachelier
force-pushed
the
jscs-update
branch
from
413640d
to
62876f7
Compare
|
@arthurvr rebased on master |
|
Looks good to me |
|
Thanks @stephanebachelier :) |
Closed
|
fix #482 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.