Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work on embedded videos? #63

Closed
TroudhuK opened this issue Oct 8, 2017 · 4 comments
Closed

Doesn't work on embedded videos? #63

TroudhuK opened this issue Oct 8, 2017 · 4 comments
Labels

Comments

@TroudhuK
Copy link

TroudhuK commented Oct 8, 2017

Is it supposed to work for embedded videos, like YTC, or not yet?

If I ask for that, of course, it's because it doesn't work for me but I have a lot of other extensions, protections etc. so maybe it's a specific problem to me.

@YePpHa YePpHa added the bug label Oct 8, 2017
@YePpHa
Copy link
Owner

YePpHa commented Oct 8, 2017

Seems like I'm calling some player methods that are not available for the embedded videos. I will replace those with method that are available for the embedded videos. Moreover, I also found out that the quality module didn't work due to some timing issue.

I might want to separate some settings to allow different settings for embedded, detail page and profile page videos. However, I wont be doing that yet.

The following modules should work in the next alpha version:

  • adblock
  • quality
  • player element focus

@YePpHa
Copy link
Owner

YePpHa commented Oct 8, 2017

Version that fixes this https://github.com/YePpHa/maia-yt/releases/tag/v0.1-alpha.6

@YePpHa YePpHa closed this as completed Oct 8, 2017
@TroudhuK
Copy link
Author

TroudhuK commented Oct 8, 2017

Nice, it works... if you remove // @noframes ;-)

@YePpHa
Copy link
Owner

YePpHa commented Oct 8, 2017

Ahh yeah, the @noframes metadata. I could remove it, but GreaseMonkey in the future will always have @noframes turned on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants