Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

discriminator output['y_c'] never used #7

Closed
mayfool opened this issue Aug 4, 2022 · 2 comments
Closed

discriminator output['y_c'] never used #7

mayfool opened this issue Aug 4, 2022 · 2 comments

Comments

@mayfool
Copy link

mayfool commented Aug 4, 2022

Discriminator's output['y_c'] never used, and never calculated in discriminator forward func. What does this variable mean?

p, pc = o['y'], o['y_c']

@yerfor
Copy link
Owner

yerfor commented Aug 4, 2022

Hi there, this is some history code that needs to be deleted. In the current code, this line will never be called.
Actually, 'y_c' is the abbreviation of 'y_conditioned'. We have tried discriminators conditioned on other features, but it doesn't bring noticeable improvement.

@yerfor yerfor closed this as completed Aug 4, 2022
@mayfool
Copy link
Author

mayfool commented Aug 5, 2022

Thanks for reply.

Hi there, this is some history code that needs to be deleted. In the current code, this line will never be called. Actually, 'y_c' is the abbreviation of 'y_conditioned'. We have tried discriminators conditioned on other features, but it doesn't bring noticeable improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants