New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add insertUniqueEntity method #718

Merged
merged 4 commits into from Oct 21, 2017

Conversation

Projects
None yet
2 participants
@cdepillabout
Contributor

cdepillabout commented Oct 21, 2017

This PR adds a insertUniqueEntity helper method.

This is a combination of insertEntity and insertUnique:

insertEntity :: record -> ReaderT backend m (Entity record)

insertUnique :: record -> ReaderT backend m (Maybe (Key record))

insertUniqueEntity :: record -> ReaderT backend m (Maybe (Entity record))

cdepillabout added some commits Oct 21, 2017

Add insertUniqueEntity method.
This commit adds an insertUniqueEntity method, which is a combination of
insertUnique and insertEntity.
@psibi

This comment has been minimized.

Show comment
Hide comment
@psibi

psibi Oct 21, 2017

Member

Can you add @since haddock markup for the introduced function add add corresponding changelog ?

Member

psibi commented Oct 21, 2017

Can you add @since haddock markup for the introduced function add add corresponding changelog ?

@cdepillabout

This comment has been minimized.

Show comment
Hide comment
@cdepillabout

cdepillabout Oct 21, 2017

Contributor

@psibi Thanks for the review. The @since annotation and changelog entry have been added in commit de5c7e1.

Contributor

cdepillabout commented Oct 21, 2017

@psibi Thanks for the review. The @since annotation and changelog entry have been added in commit de5c7e1.

@psibi psibi merged commit bddb397 into yesodweb:master Oct 21, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@psibi

This comment has been minimized.

Show comment
Hide comment
@psibi

psibi Oct 21, 2017

Member

Thanks for the PR!

Member

psibi commented Oct 21, 2017

Thanks for the PR!

@cdepillabout cdepillabout deleted the cdepillabout:add-insert-unique-entity-method branch Oct 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment