-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for SQL isolation levels #812
Conversation
…ion within transactions.
I don't feel very competent to approve this, especially for postgresql which I haven't used for years, but, that said, I've looked through the changes and they seem to be fine. If nobody else steps in with comments, I'll go ahead in a few days. |
Hi @paul-rouse, any chance you're ready to merge this yet? |
I'll take a look at this as I'm an active Persistent + PostgreSQL user. |
Thanks @bitemyapp ! |
This is a very neat PR. Thank you @iand675, good seeing you around too :) |
@bitemyapp Glad to you like it! Any notion on when it'll go up on hackage? Waiting to merge the corresponding yesod PRs til this is all the way shipped. |
@iand675 I'll take a sweep of open PRs this weekend, see what can make it in. |
Quickly wanted to check in and see if this can go to hackage/stackage. Otherwise would you recommend pinning this hash? |
This adds support for assorted SQL isolation levels to all of the standard SQL backends.
There is a slight breaking change for any dependent SQL backends in that the
connBegin
function now takes an optional isolation level argument. This is necessary because for MySQL the transaction isolation level must be specified before callingbegin
.@since
declarations to the HaddockAfter submitting your PR: