Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subsite with typeclass contexts and type variables #32

Merged
merged 1 commit into from
Jun 13, 2017

Conversation

jprider63
Copy link
Contributor

I wasn't sure what category to add this to, but "Routing" seemed to make the most sense. Is there anything else you'd like me to add?

@psibi
Copy link
Member

psibi commented Apr 4, 2017

@jprider63 I will merge this once your code is merged there. Thanks!

@ajnsit
Copy link

ajnsit commented Apr 4, 2017

This will be great for wai-routes as well. Since subsites currently use typeclass definitions, but this would help them go the other way round (i.e. use simple types).

@psibi
Copy link
Member

psibi commented Jun 1, 2017

@jprider63 Is there any motivation for having typeclass contexts and type variables ?

@jprider63
Copy link
Contributor Author

My use case is I'm writing a subsite where the types are dependent on the parent site. I've written more about it in this post and this issue (yesodweb/yesod#1365).

@psibi psibi merged commit 8365417 into yesodweb:master Jun 13, 2017
@psibi
Copy link
Member

psibi commented Jun 13, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants