Contexts can be parsed and included in instances. Standalone deriving… #1366
Conversation
… is used when a context is provided. Type variables can be included in routes/TH.
|
LGTM. Can you add a comment to the changelog explaining the changes and make a minor version bump in the cabal file? |
|
Done. For some reason Travis didn't test the second commit. I fixed an issue so it should work with old versions of template-haskell as well. |
|
@jprider63 Can you document about how to use this new feature either in the cookbook https://github.com/yesodweb/yesod-cookbook or the yesod book if itsn't too much work ? |
|
Sure, I can add an example to the cookbook when I have some time. Would an example subsite with type variables and contexts make sense? |
|
Yeah, that should do.
…On Fri, Mar 31, 2017, 12:05 AM JP ***@***.***> wrote:
Sure, I can add an example to the cookbook when I have some time. Would an
example subsite with type variables and contexts make sense?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1366 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAtAxaFIWakB0K-os6cZDXU1jqgNHxQJks5rq_YBgaJpZM4Mpxqw>
.
|
|
I just added the example to the cookbook and created a pull request. |
|
Is there anything else you'd like me to do before merging this? |
|
@jprider63 There seems to be merge conflict with the PR. |
|
The changelog changed since I wrote this. I've bumped the version and fixed the conflict. |
|
@snoyberg Can this be merged ? |
|
LGTM, thanks! |
… is used when a context is provided. Type variables can be included in routes/TH.