Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[yesod] Fix comment for contentTypeTypes & simpler implementation #1476

Merged
merged 2 commits into from
Feb 2, 2018
Merged

[yesod] Fix comment for contentTypeTypes & simpler implementation #1476

merged 2 commits into from
Feb 2, 2018

Conversation

JaSpa
Copy link
Contributor

@JaSpa JaSpa commented Jan 18, 2018

In the implementation of contentTypeTypes there is no need to repeat the logic from simpleContentType which is defined just above it.


Before submitting your PR, check that you've:

  • Bumped the version number

After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

@snoyberg
Copy link
Member

Thanks, I've merged this into #1464.

@snoyberg snoyberg merged commit 4921025 into yesodweb:master Feb 2, 2018
@JaSpa JaSpa deleted the simple-content-type branch February 3, 2018 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants