Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Reloading maps view causes favorited routes to be selected regardless of menu check #59

Closed
yeSpud opened this issue Mar 23, 2021 · 0 comments · Fixed by #58
Closed
Labels
Bug 🐛 Something isn't working as intended Pending Pull Request ✅ The Issue / Enhancement that has been fixed / implemented in the Beta and needs a Pull Request

Comments

@yeSpud
Copy link
Owner

yeSpud commented Mar 23, 2021

Describe the bug
Whatever routes are favorited are selected upon loading the MapsActivity (like from returning from the SettingsActivity, or going to the home screen, and returning the app). When doing so the checkboxes in the dropdown are not updated correctly.

To Reproduce
Steps to reproduce the behavior:

  1. Launch the app with favorite routes.
  2. Change which routes are selected from the drop-down menu.
  3. Go to a different view/activity.
  4. Return to the MapsActivity.
  5. Notice how the selected routes have seemingly re-enabled favorited routes, but not selected them from the drop-down.

Expected behavior
Favorite routes should only be pre-selected upon the first load coming from SplashActivity.

Smartphone (please complete the following information):

  • Device: OnePlus 5T
  • OS: Android 10.
  • App version: Release 1.2.2
@yeSpud yeSpud added the Bug 🐛 Something isn't working as intended label Mar 23, 2021
@yeSpud yeSpud self-assigned this Mar 23, 2021
yeSpud added a commit that referenced this issue Mar 23, 2021
@yeSpud yeSpud mentioned this issue Mar 23, 2021
@yeSpud yeSpud removed their assignment Mar 23, 2021
@yeSpud yeSpud added the Pending Pull Request ✅ The Issue / Enhancement that has been fixed / implemented in the Beta and needs a Pull Request label Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug 🐛 Something isn't working as intended Pending Pull Request ✅ The Issue / Enhancement that has been fixed / implemented in the Beta and needs a Pull Request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant