Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Network timeout change #60

Closed
yeSpud opened this issue Apr 2, 2021 · 2 comments · Fixed by #58
Closed

Feature: Network timeout change #60

yeSpud opened this issue Apr 2, 2021 · 2 comments · Fixed by #58
Labels
Feature Request / Enhancement ✨ New feature or request Pending Pull Request ✅ The Issue / Enhancement that has been fixed / implemented in the Beta and needs a Pull Request

Comments

@yeSpud
Copy link
Owner

yeSpud commented Apr 2, 2021

Describe the feature you'd like to see added
Looking into the response times for masterRoute (https://fnsb.routematch.com/feed/masterRoute/) it seems that average response times take about a minute to come through.

Becasue of this the timeout should be changed to 70 seconds, and maybe even have an option to run without a timeout (for initialization requests).
@yeSpud yeSpud added Feature Request / Enhancement ✨ New feature or request To Be Done Later 🗓 For bug fixes / enhancements that can be completed further down the line. labels Apr 2, 2021
@yeSpud yeSpud self-assigned this Apr 2, 2021
@yeSpud yeSpud removed the To Be Done Later 🗓 For bug fixes / enhancements that can be completed further down the line. label Apr 2, 2021
@yeSpud
Copy link
Owner Author

yeSpud commented Apr 2, 2021

Theres already a parameter to run without timeouts that I forgot about.

Oops.

@yeSpud
Copy link
Owner Author

yeSpud commented Apr 2, 2021

Can probably constrain it to 65 seconds

yeSpud added a commit that referenced this issue Apr 2, 2021
@yeSpud
Fixed #60
191c330
@yeSpud yeSpud removed their assignment Apr 2, 2021
@yeSpud yeSpud added the Pending Pull Request ✅ The Issue / Enhancement that has been fixed / implemented in the Beta and needs a Pull Request label Apr 2, 2021
@yeSpud yeSpud linked a pull request Apr 2, 2021 that will close this issue
Release 1.2 #58
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature Request / Enhancement ✨ New feature or request Pending Pull Request ✅ The Issue / Enhancement that has been fixed / implemented in the Beta and needs a Pull Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Release 1.2 yeSpud/MACSTransitApp
1 participant
@yeSpud