Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Volume Unit Converter is seriously inaccurate #33

Closed
jasyip opened this issue Feb 1, 2023 · 2 comments · Fixed by #34
Closed

Volume Unit Converter is seriously inaccurate #33

jasyip opened this issue Feb 1, 2023 · 2 comments · Fixed by #34
Assignees
@Yet-Zio
Labels
code-issue A result, feature or property in the app that does not yield the correct result due to known changes converter Issues, pull requests or discussions concerning the converter mode. important Issues, pull requests or discussions that require immediate action

Comments

@jasyip
Copy link

jasyip commented Feb 1, 2023

Screenshot_20230201-085843_yetCalc
There's no way that is right. 1 cup should be 16 tablespoons

My settings:
Screenshot_20230201-090031_yetCalc
@Yet-Zio Yet-Zio self-assigned this Feb 1, 2023
@Yet-Zio Yet-Zio added converter Issues, pull requests or discussions concerning the converter mode. code-issue A result, feature or property in the app that does not yield the correct result due to known changes labels Feb 1, 2023
@Yet-Zio
Copy link
Owner

Yet-Zio commented Feb 1, 2023

@jasyip Thanks for noting that out. Seems I didn't notice that at the recent release. The issue will be fixed asap. There were some approximations made for some units and that tend to have been wrong, this is one of the those I forgot to change.

Sorry for any inconvenience.

@Yet-Zio Yet-Zio added the important Issues, pull requests or discussions that require immediate action label Feb 1, 2023
@Yet-Zio Yet-Zio linked a pull request Feb 1, 2023 that will close this issue
v1.0.6 #34
Merged
@Yet-Zio Yet-Zio mentioned this issue Feb 1, 2023
Merged
@Yet-Zio
Copy link
Owner

Yet-Zio commented Feb 1, 2023

Fixed as of #34 . Feel free to report any more issues, as the unit converter might have inaccuracies regarding certain units as there are so many to focus on. :).

@Yet-Zio Yet-Zio closed this as completed Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Yet-Zio Yet-Zio

Labels
code-issue A result, feature or property in the app that does not yield the correct result due to known changes converter Issues, pull requests or discussions concerning the converter mode. important Issues, pull requests or discussions that require immediate action
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

v1.0.6 Yet-Zio/yetCalc
2 participants
@jasyip @Yet-Zio