Refactor vlist to use less macros and unsafe #2195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An ElementWriter struct keeps track of the place where to insert elements, instead of the previous apply! macro. The Vec::drain api is used consume ancestors. This removes a panic unsafety: the previous impl forgets to drop elements Small fix: author -> authors in web_worker_fib
|
This is something I haven't really touched much so it'd be better if someone with more experience can take a look at this |
siku2
approved these changes
Nov 27, 2021
mc1098
approved these changes
Nov 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactors
yew::virtual_dom::vlistto be more idiomatic rust.An
ElementWriterstruct keeps track of the place where to insert elements, instead of the previousapply!macro.The
Vec::drainAPI is used to consume ancestors. This removes a previous worry where panic doesn't drop the remaining elements.No changes to algorithmic nor runtime behaviour in this PR.
Additional small fix, cause I noticed a warning: author -> authors in
web_worker_fib.Checklist
cargo make pr-flow