Add wasm32-unknown-unknown target instruction & update trunk install instructions #2370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Impl IntoOptPropValue for Option<V> -> Option<T> The only implmented types passed to impl_into_prop macro * Update packages/yew/src/html/conversion.rs sure Co-authored-by: Simon <simon@siku2.io> Co-authored-by: Simon <simon@siku2.io>
This reverts commit 7236843.
Would solve the issue described here: #1862 I was having the same problem.
hamza1311
requested changes
Jan 14, 2022
hamza1311
previously approved these changes
Jan 14, 2022
hamza1311
changed the title
|
@leontepe, you were basing off of an old branch. I updated it. Can you rebase? |
voidpumpkin
added
the
S-waiting-on-author
1 similar comment
ghost
closed this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
wasm32-unknown-unknowntarget with rustup as a step to get the examples running.Fixes #1862. Had the same issue myself.