Update FAQ card to support answerV2 instead of answer #1142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
J=BACK-2436 TEST=manual Created test site using jambo template and verified that FAQ answer was rendered properly
cea2aj
reviewed
Aug 14, 2023
cards/faq-accordion/component.js
Outdated
| if (profile.answerV2 && profile.answerV2.html) { | ||
| profileAnswer = profile.answerV2.html; | ||
| } else if (profile.answerV2 && profile.answerV2.json) { | ||
| console.warn('JSON is not supported, please switch to HTML.') |
There was a problem hiding this comment.
nit: I think we should say use the word 'convert' rather than 'switch' because the feature on the backend uses the word 'convert' as well
There was a problem hiding this comment.
updated in most recent commit
cea2aj
reviewed
Aug 14, 2023
|
|
||
| return { | ||
| title: profile.question || profile.name, // The header text of the card | ||
| // subtitle: '', // The sub-header text of the card | ||
| details: profile.answer ? ANSWERS.formatRichText(profile.answer, "answer", linkTarget) : null, // The text in the body of the card |
There was a problem hiding this comment.
I think it would be a good idea to add a 3rd if statement which maintains this functionality of calling ANSWERS.formatRichText if profile.answers exists. That way if someone upgrades to this version of the hitchhiker-theme, it won't break any existing sites which use the faq-accordion card
There was a problem hiding this comment.
that makes sense! i've added that check into the logic in the most recent commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
J=BACK-2436
TEST=manual
Created test site using jambo template and verified that FAQ answer was rendered properly