Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing translation tests #1147

Merged
merged 1 commit into from
Aug 14, 2023
Merged

Fix failing translation tests #1147

merged 1 commit into from
Aug 14, 2023

Conversation

cea2aj
Copy link
Member

@cea2aj cea2aj commented Aug 14, 2023 •
edited
Loading

The translation files were failing because the line numbers in the multilang-accordion card changed

I ran npm run extract-translations to update the files

J=BACK-2463
TEST=manual

Confirmed tests now pass

@coveralls
Copy link

Coverage Status

coverage: 8.737%. remained the same when pulling b442d88 on dev/fix-translations into 5e117fa on develop.

@likimmy likimmy self-requested a review August 14, 2023 20:51
likimmy
likimmy approved these changes Aug 14, 2023
View reviewed changes
Copy link
Contributor

@likimmy likimmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@likimmy likimmy mentioned this pull request Aug 14, 2023
Merged
@cea2aj cea2aj merged commit f84e49e into develop Aug 14, 2023
16 of 17 checks passed
@cea2aj cea2aj deleted the dev/fix-translations branch August 14, 2023 20:53
likimmy added a commit that referenced this pull request Aug 14, 2023
@likimmy
Version 1.33.0 (#1146)
0222c71 
## v1.33.0

### Changes

- Update FAQ card to support answerV2 instead of answer (#1142)
- Update corresponding translation tests for above changes (#1147)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@likimmy likimmy likimmy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cea2aj @coveralls @likimmy