Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 1.33.0 #1146

Merged
merged 8 commits into from
Aug 14, 2023
Merged

Version 1.33.0 #1146

merged 8 commits into from
Aug 14, 2023

Conversation

likimmy
Copy link
Contributor

@likimmy likimmy commented Aug 14, 2023

v1.33.0

Changes

likimmy and others added 7 commits August 14, 2023 11:04
J=BACK-2436
TEST=manual

Created test site using jambo template and verified that FAQ answer was rendered properly
Update FAQ card to support answerV2 instead of answer
Bump the version number for v1.33.0

J=BACK-2436
TEST=none
Add version number updates to package-lock.json files
@likimmy likimmy requested a review from cea2aj August 14, 2023 20:17
@likimmy likimmy changed the title Develop Version 1.33.0 Aug 14, 2023
@coveralls
Copy link

coveralls commented Aug 14, 2023

Coverage Status

coverage: 8.737%. remained the same when pulling f84e49e on develop into 7c3bb22 on master.

The translation files were failing because the line numbers in the multilang-accordion card changed

I ran `npm run extract-translations` to update the files

J=BACK-2463
TEST=manual

Confirmed tests now pass
Copy link
Member

@cea2aj cea2aj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@likimmy likimmy merged commit 0222c71 into master Aug 14, 2023
25 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants