Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix custom search icon size #992

Merged
merged 5 commits into from
Nov 2, 2021
Merged

Conversation

oshi97
Copy link
Contributor

@oshi97 oshi97 commented Nov 2, 2021

fix custom search icon size

Removes custom aeb styling that was causing search icons to be too large.

J=SLAP-1654
TEST=manual,auto

tweaked the snapshot config to test these
saw no issues with a custom submitIcon or customIconUrl
loading indicator worked as expected

Removes custom aeb styling that was causing search icons to be too large.

TEST=manual,auto

tweaked the snapshot config to test these
saw no issues with a custom submitIcon or customIconUrl
loading indicator worked as expected
@coveralls
Copy link

coveralls commented Nov 2, 2021

Coverage Status

Coverage remained the same at 9.19% when pulling d3f12ab on dev/custom-search-icon-css-fix into 7624a2b on develop.

@oshi97 oshi97 merged commit c47b3e3 into develop Nov 2, 2021
@oshi97 oshi97 deleted the dev/custom-search-icon-css-fix branch November 2, 2021 21:52
@nmanu1 nmanu1 mentioned this pull request Nov 16, 2021
nmanu1 added a commit that referenced this pull request Nov 16, 2021
## Version 1.26.0
### Features
- Add support for the auth token, with a new global_config `token` field  (#976)
- Add support for the visitor, which can be set or changed at runtime (#970)
- Add support for generic thumbs up/down feedback buttons to all cards (#973, #1005)
- Handle page and template names with spaces (#988)

### Changes
- Update styling of navigation ‘More’ menu (#989)
- Update hover color of search bar buttons (#1000)
- Internal repo changes (automate WCAG testing (#987))

### Bugfixes
- Fix console error which would appear on google maps (#955)
- Fix extra query when loading in iframe integrations (#986)
- Fix bug that displayed links that didn’t exist (#990)
- Allow microphone access for voice search in iframe (#991)
- Fix issue with custom search icon size (#992)
- Fix bug with new prop comments not being added (#1004)
- Fix distance alignment on location cards (#1006)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants