Card layout updates #1005
Merged
Card layout updates #1005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oshi97
reviewed
Nov 15, 2021
static/scss/answers/cards/product-prominentimage-clickable.scss
Outdated
Show resolved
Hide resolved
nmanu1
reviewed
Nov 15, 2021
oshi97
reviewed
Nov 15, 2021
nmanu1
reviewed
Nov 15, 2021
yen-tt
approved these changes
Nov 15, 2021
Merged
nmanu1
added a commit
that referenced
this pull request
Nov 16, 2021
## Version 1.26.0 ### Features - Add support for the auth token, with a new global_config `token` field (#976) - Add support for the visitor, which can be set or changed at runtime (#970) - Add support for generic thumbs up/down feedback buttons to all cards (#973, #1005) - Handle page and template names with spaces (#988) ### Changes - Update styling of navigation ‘More’ menu (#989) - Update hover color of search bar buttons (#1000) - Internal repo changes (automate WCAG testing (#987)) ### Bugfixes - Fix console error which would appear on google maps (#955) - Fix extra query when loading in iframe integrations (#986) - Fix bug that displayed links that didn’t exist (#990) - Allow microphone access for voice search in iframe (#991) - Fix issue with custom search icon size (#992) - Fix bug with new prop comments not being added (#1004) - Fix distance alignment on location cards (#1006)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the layout of the card feedback buttons so that they are located in their own row underneath the CTAs and the card content
This change was in response to feedback from Product/UX. This PR moves the feedback buttons out from the
HitchhikerCard-actionsdiv into the card body. We also remove theHichhikerCard-actionsdiv since that was only there so that the buttons could be next to the CTAs. This allows the card content to be full width when CTAs are not present. It adds some extra height to most cards since there's an entire row dedicated to the feedback buttons, however UX was happy with this decision. As part of this change, I removed some styling which is no longer relevant.This PR also ensures that the feedback buttons are in the bottom right on grid layout. (Previously the buttons could appear just below the card content in grid layout just below the CTAs)
Also set a fixed feedbackContent height so that the cards don't shift when the buttons are pressed.
J=SLAP-1702
TEST=manual
Visual inspect all cards with feedback buttons enabled and also check mobile layouts. Test the product cards on the grid layout and confirm the feedback buttons are in the bottom right. Test clicking the feedback buttons and observing that the cards do not shift