set SEARCH_COMPLETE state for necessary models when an API error occurs #1702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now when an API error occurs, the SEARCH_COMPLETE state is set for models that are set to SEARCH_LOADING. J=SLAP-1467 TEST=manual set an invalid apiKey, see the search loading state start and stop as expected see expected console log for both universal + vertical searches also do the same thing with an invalid verticalKey for vertical searches see that no location bias or direct answer renders after an API error
Merged
nmanu1
added a commit
that referenced
this pull request
May 10, 2022
## Version 1.14.0 ### Features - Added an `environment` field to support consumer auth in Sandbox (#1597) - Added support for search duration metrics on desktop and mobile (#1677, #1678, #1684, #1729) - Added support for passing Answers Agents in the HTTP header (#1686) - Added support for adding custom autocomplete prompts (#1655, #1699) - Added support for number range facets (#1707) - Added additional params to `formatRichText` for RTF truncation support (#1713, #1714) ### Changes - Updated the `directAnswers` component data to include the searcher (#1596) - Updated the README to reflect all required fields for `FilterSearch` (#1598) - Changed `FilterSearchResponse` to match the updated Core model (#1599) - Updated map controls to match the Theme (#1648) - Removed unused `verticalKey` config from `Facets` and `FilterBox` (#1724) ### Bug Fixes - Updated pin label to ensure correct ordering with card ordinal (#1643) - Fixed loading indicator in Safari and IE11 (#1650) - Only display voice search icon on mobile when supported (#1662) - Updated `redirectUrl` URL construction to prioritize user-specified params (#1667) - Updated to allow both Google and MabBox maps on the same page (#1687) - Updated to set the SEARCH_COMPLETE state if an API error occurs (#1702) - Moved the `aria-expanded` attribute to autocomplete text inputs (#1704) - Updated `constructRedirectUrl` to handle relative links and ensure IE support (#1733) - Modified tab url based on parent url to support correct iframe tab navigation (#1731)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now when an API error occurs, the SEARCH_COMPLETE state is set for models
that are set to SEARCH_LOADING.
J=SLAP-1467
TEST=manual
set an invalid apiKey, see the search loading state start and stop as expected
see expected console log for both universal + vertical searches
also do the same thing with an invalid verticalKey for vertical searches
see that no location bias or direct answer renders after an API error