Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update redirectUrl URL construction #1667

Merged
merged 3 commits into from
Feb 8, 2022
Merged

update redirectUrl URL construction #1667

merged 3 commits into from
Feb 8, 2022

Conversation

yen-tt
Copy link
Contributor

@yen-tt yen-tt commented Feb 8, 2022

update redirectUrl URL construction to prioritize user-specified params over answers params

J=SLAP-232
TEST=manual & auto

  • tested search bar and filter search component in chrome, safari, firefox, and ie11. Configure redirectUrl to be 'https://answers.yext.com/?query=test&another-param=stuff' and search for 'rose'. See that the redirectUrl preserve query param and other non-conflicting params from answers and user-specified ones
  • see the new jest tests passed

@coveralls
Copy link

coveralls commented Feb 8, 2022

Coverage Status

Coverage increased (+0.03%) to 61.28% when pulling eb40b9f on dev/fix-redirectUrl into 92b5fdf on develop.

@yen-tt yen-tt added the WIP Work in progress label Feb 8, 2022
@yen-tt yen-tt removed the WIP Work in progress label Feb 8, 2022
Copy link
Contributor

@oshi97 oshi97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whooo ie11 testing!!!

@yen-tt yen-tt merged commit 9aa76ef into develop Feb 8, 2022
@yen-tt yen-tt deleted the dev/fix-redirectUrl branch February 8, 2022 19:25
@nmanu1 nmanu1 mentioned this pull request May 10, 2022
nmanu1 added a commit that referenced this pull request May 10, 2022
## Version 1.14.0
### Features
- Added an `environment` field to support consumer auth in Sandbox (#1597)
- Added support for search duration metrics on desktop and mobile (#1677, #1678, #1684, #1729)
- Added support for passing Answers Agents in the HTTP header (#1686)
- Added support for adding custom autocomplete prompts (#1655, #1699)
- Added support for number range facets (#1707)
- Added additional params to `formatRichText` for RTF truncation support (#1713, #1714)

### Changes
- Updated the `directAnswers` component data to include the searcher (#1596)
- Updated the README to reflect all required fields for `FilterSearch` (#1598)
- Changed `FilterSearchResponse` to match the updated Core model (#1599)
- Updated map controls to match the Theme (#1648)
- Removed unused `verticalKey` config from `Facets` and `FilterBox` (#1724)

### Bug Fixes
- Updated pin label to ensure correct ordering with card ordinal (#1643)
- Fixed loading indicator in Safari and IE11 (#1650)
- Only display voice search icon on mobile when supported (#1662)
- Updated `redirectUrl` URL construction to prioritize user-specified params (#1667)
- Updated to allow both Google and MabBox maps on the same page (#1687)
- Updated to set the SEARCH_COMPLETE state if an API error occurs (#1702)
- Moved the `aria-expanded` attribute to autocomplete text inputs (#1704)
- Updated `constructRedirectUrl` to handle relative links and ensure IE support (#1733)
- Modified tab url based on parent url to support correct iframe tab navigation (#1731)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants