gracefully handle analytics error #1774
Conversation
|
also, I was just curious, so I looked it up and |
the default for comparision_branch for coverage workflow is "main" which we have "master" instead for SDK. updated in this pr to point to master |
A quick look at the release notes for v2 and the changes seem ok? We can make an item or a separate pr to pin to v1 in the reusuable workflow repo or pin to v2 and probably have to update the version package.json to v2 in our repos as well so it's consistent |
Yeah, that's what I was thinking. There weren't any breaking changes on the running side, only on the output produced and those changes seem fine. But, that might not be the case if they release a v3, so it would be good to pin to v2 in another item |
Throw error from not having `ytag` script tag for conversion tracking opt in would prevent a search fired on load. This is an aggressive behavior as analytics shouldn't affect search behavior. This pr updated the two throw error into console error instead. Same as #1771 but without acceptance tests changes TEST=manual Added `ANSWERS.setConversionsOptIn(true);` to a local index page with Answers setup. see that the previously uncaught throw error is now a console error and a search on load is no longer blocked. <img width="1786" alt="Screen Shot 2022-08-31 at 8 36 25 AM" src="https://user-images.githubusercontent.com/36055303/187679764-b5c9a6e6-bf12-4467-a42b-66fb3052846d.png">
Throw error from not having `ytag` script tag for conversion tracking opt in would prevent a search fired on load. This is an aggressive behavior as analytics shouldn't affect search behavior. This pr updated the two throw error into console error instead. Same as #1771 but without acceptance tests changes TEST=manual Added `ANSWERS.setConversionsOptIn(true);` to a local index page with Answers setup. see that the previously uncaught throw error is now a console error and a search on load is no longer blocked. <img width="1786" alt="Screen Shot 2022-08-31 at 8 36 25 AM" src="https://user-images.githubusercontent.com/36055303/187679764-b5c9a6e6-bf12-4467-a42b-66fb3052846d.png">
Throw error from not having
ytagscript tag for conversion tracking opt in would prevent a search fired on load. This is an aggressive behavior as analytics shouldn't affect search behavior. This pr updated the two throw error into console error instead.Same as #1771 but without acceptance tests changes
TEST=manual
Added
ANSWERS.setConversionsOptIn(true);to a local index page with Answers setup. see that the previously uncaught throw error is now a console error and a search on load is no longer blocked.