switch throw to console error in analytics reporter #1771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
do we need to update support branches? (ideally we don't but wanted to check) |
nmanu1
reviewed
Aug 30, 2022
This hofix branch v1.13.1 will go into support branch v1.13. I will also make a hotfix branch for v1.14.2 |
nmanu1
approved these changes
Aug 30, 2022
nmanu1
previously requested changes
Aug 30, 2022
nmanu1
reviewed
Aug 30, 2022
nmanu1
reviewed
Aug 30, 2022
nmanu1
reviewed
Aug 30, 2022
added 2 commits
August 30, 2022 18:46
nmanu1
reviewed
Aug 30, 2022
looks unrelated, I will run again to see if it's spurious |
I think v1.13 is from before we mocked the acceptance test fixtures, so it might just be that the response changed and needs to be updated |
yea, was seeing if the answers experience match the new expected before making changes. It seems like we turned on facets for c_cellPhone and removed some entities data for c_popularities so those caused the acceptance test to fail. I was fiddling with the experience config but thought I should just update the response here anyway like you said. |
tmeyer2115
approved these changes
Aug 30, 2022
Merged
yen-tt
added a commit
that referenced
this pull request
Aug 31, 2022
Throw error from not having `ytag` script tag for conversion tracking opt in would prevent a search fired on load. This is an aggressive behavior as analytics shouldn't affect search behavior. This pr updated the two throw error into console error instead. Same as #1771 but without acceptance tests changes TEST=manual Added `ANSWERS.setConversionsOptIn(true);` to a local index page with Answers setup. see that the previously uncaught throw error is now a console error and a search on load is no longer blocked. <img width="1786" alt="Screen Shot 2022-08-31 at 8 36 25 AM" src="https://user-images.githubusercontent.com/36055303/187679764-b5c9a6e6-bf12-4467-a42b-66fb3052846d.png">
yen-tt
added a commit
that referenced
this pull request
Sep 2, 2022
Throw error from not having `ytag` script tag for conversion tracking opt in would prevent a search fired on load. This is an aggressive behavior as analytics shouldn't affect search behavior. This pr updated the two throw error into console error instead. TEST=manual Added `ANSWERS.setConversionsOptIn(true);` to a local index page with Answers setup. see that the previously uncaught throw error is now a console error and a search on load is no longer blocked. <img width="1782" alt="Screen Shot 2022-08-30 at 5 06 28 PM" src="https://user-images.githubusercontent.com/36055303/187543204-d6acca4d-9cbc-47db-a51d-2ca88b36aa34.png">
Merged
yen-tt
added a commit
that referenced
this pull request
Sep 2, 2022
Throw error from not having `ytag` script tag for conversion tracking opt in would prevent a search fired on load. This is an aggressive behavior as analytics shouldn't affect search behavior. This pr updated the two throw error into console error instead. Same as #1771 but without acceptance tests changes TEST=manual Added `ANSWERS.setConversionsOptIn(true);` to a local index page with Answers setup. see that the previously uncaught throw error is now a console error and a search on load is no longer blocked. <img width="1786" alt="Screen Shot 2022-08-31 at 8 36 25 AM" src="https://user-images.githubusercontent.com/36055303/187679764-b5c9a6e6-bf12-4467-a42b-66fb3052846d.png">
yen-tt
added a commit
that referenced
this pull request
Sep 2, 2022
Throw error from not having `ytag` script tag for conversion tracking opt in would prevent a search fired on load. This is an aggressive behavior as analytics shouldn't affect search behavior. This pr updated the two throw error into console error instead. Same as #1771 but without acceptance tests changes TEST=manual Added `ANSWERS.setConversionsOptIn(true);` to a local index page with Answers setup. see that the previously uncaught throw error is now a console error and a search on load is no longer blocked. <img width="1786" alt="Screen Shot 2022-08-31 at 8 36 25 AM" src="https://user-images.githubusercontent.com/36055303/187679764-b5c9a6e6-bf12-4467-a42b-66fb3052846d.png">
Merged
yen-tt
added a commit
that referenced
this pull request
Sep 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Throw error from not having
ytagscript tag for conversion tracking opt in would prevent a search fired on load. This is an aggressive behavior as analytics shouldn't affect search behavior. This pr updated the two throw error into console error instead.TEST=manual
Added
ANSWERS.setConversionsOptIn(true);to a local index page with Answers setup. see that the previously uncaught throw error is now a console error and a search on load is no longer blocked.