Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin the Google Maps API version to v3.47. #1681

Merged
merged 1 commit into from
Mar 10, 2022

Conversation

tmeyer2115
Copy link
Collaborator

See this piece of documentation: https://developers.google.com/maps/documentation/javascript/browsersupport.
Version 3.47 of the Maps Javascript API will be the last version to support IE11.

TEST=manual

See this piece of documentation: https://developers.google.com/maps/documentation/javascript/browsersupport.
Version 3.47 of the Maps Javascript API will be the last version to support IE11.

TEST=manual

Saw v3.47 of the API being used. Saw Google Maps appear on Universal as expected.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 61.329% when pulling 0a2cc29 on dev/pin-google-maps-version into ddd8172 on hotfix/v1.12.2.

@tmeyer2115 tmeyer2115 merged commit e9a87a7 into hotfix/v1.12.2 Mar 10, 2022
@tmeyer2115 tmeyer2115 mentioned this pull request Mar 10, 2022
tmeyer2115 added a commit that referenced this pull request Mar 10, 2022
### Bug Fixes
- The `answers-core` version was updated to v1.5.1. This new version ensures that Core's POST requests only have `credentials: include` when there is an `Authorization` header. Previously, Core would always have `credentials: include` on POST which led to CORS issues when trying to submit a question. 
- The SDK's wrapper around `answers-core` now gracefully handles LiveAPI failures. (#1669)
- In the `SearchBar` Component, we now gracefully handle failures when fetching query intents. So, if we are unable to determine if a query has `NEAR_ME` intent, we will still fire off a search and display an error in the `console`. (#1673)
- Pinned the Google Maps Javascript API version to v3.47. This is the last version that will support IE11. (#1681)
@oshi97 oshi97 deleted the dev/pin-google-maps-version branch March 15, 2022 21:15
cea2aj pushed a commit that referenced this pull request Apr 8, 2022
See this piece of documentation: https://developers.google.com/maps/documentation/javascript/browsersupport.
Version 3.47 of the Maps Javascript API will be the last version to support IE11.

TEST=manual

Saw v3.47 of the API being used. Saw Google Maps appear on Universal as expected.
cea2aj pushed a commit that referenced this pull request Apr 8, 2022
See this piece of documentation: https://developers.google.com/maps/documentation/javascript/browsersupport.
Version 3.47 of the Maps Javascript API will be the last version to support IE11.

TEST=manual

Saw v3.47 of the API being used. Saw Google Maps appear on Universal as expected.
cea2aj pushed a commit that referenced this pull request Apr 8, 2022
See this piece of documentation: https://developers.google.com/maps/documentation/javascript/browsersupport.
Version 3.47 of the Maps Javascript API will be the last version to support IE11.

TEST=manual

Saw v3.47 of the API being used. Saw Google Maps appear on Universal as expected.
tmeyer2115 added a commit that referenced this pull request Sep 2, 2022
See this piece of documentation: https://developers.google.com/maps/documentation/javascript/browsersupport.
Version 3.47 of the Maps Javascript API will be the last version to support IE11.

TEST=manual

Saw v3.47 of the API being used. Saw Google Maps appear on Universal as expected.
@tmeyer2115 tmeyer2115 mentioned this pull request Sep 2, 2022
tmeyer2115 added a commit that referenced this pull request Sep 2, 2022
### Bug Fixes
- Gracefully handle analytics-related error to prevent uncaught errors from blocking the search on load. (#1774)
- Pinned the Google Maps API version to v3.47. This is the last one to officially support IE11. (#1681)
@yen-tt yen-tt mentioned this pull request Sep 2, 2022
yen-tt added a commit that referenced this pull request Sep 2, 2022
### Bug Fixes
- Gracefully handle analytics-related error to prevent uncaught errors from blocking the search on load. (#1771 )
- Pinned the Google Maps API version to v3.47. This is the last one to officially support IE11. (#1681)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants