-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin the Google Maps API version to v3.47. #1681
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See this piece of documentation: https://developers.google.com/maps/documentation/javascript/browsersupport. Version 3.47 of the Maps Javascript API will be the last version to support IE11. TEST=manual Saw v3.47 of the API being used. Saw Google Maps appear on Universal as expected.
Merged
tmeyer2115
added a commit
that referenced
this pull request
Mar 10, 2022
### Bug Fixes - The `answers-core` version was updated to v1.5.1. This new version ensures that Core's POST requests only have `credentials: include` when there is an `Authorization` header. Previously, Core would always have `credentials: include` on POST which led to CORS issues when trying to submit a question. - The SDK's wrapper around `answers-core` now gracefully handles LiveAPI failures. (#1669) - In the `SearchBar` Component, we now gracefully handle failures when fetching query intents. So, if we are unable to determine if a query has `NEAR_ME` intent, we will still fire off a search and display an error in the `console`. (#1673) - Pinned the Google Maps Javascript API version to v3.47. This is the last version that will support IE11. (#1681)
cea2aj
pushed a commit
that referenced
this pull request
Apr 8, 2022
See this piece of documentation: https://developers.google.com/maps/documentation/javascript/browsersupport. Version 3.47 of the Maps Javascript API will be the last version to support IE11. TEST=manual Saw v3.47 of the API being used. Saw Google Maps appear on Universal as expected.
cea2aj
pushed a commit
that referenced
this pull request
Apr 8, 2022
See this piece of documentation: https://developers.google.com/maps/documentation/javascript/browsersupport. Version 3.47 of the Maps Javascript API will be the last version to support IE11. TEST=manual Saw v3.47 of the API being used. Saw Google Maps appear on Universal as expected.
cea2aj
pushed a commit
that referenced
this pull request
Apr 8, 2022
See this piece of documentation: https://developers.google.com/maps/documentation/javascript/browsersupport. Version 3.47 of the Maps Javascript API will be the last version to support IE11. TEST=manual Saw v3.47 of the API being used. Saw Google Maps appear on Universal as expected.
tmeyer2115
added a commit
that referenced
this pull request
Sep 2, 2022
See this piece of documentation: https://developers.google.com/maps/documentation/javascript/browsersupport. Version 3.47 of the Maps Javascript API will be the last version to support IE11. TEST=manual Saw v3.47 of the API being used. Saw Google Maps appear on Universal as expected.
Merged
tmeyer2115
added a commit
that referenced
this pull request
Sep 2, 2022
Merged
yen-tt
added a commit
that referenced
this pull request
Sep 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See this piece of documentation: https://developers.google.com/maps/documentation/javascript/browsersupport.
Version 3.47 of the Maps Javascript API will be the last version to support IE11.
TEST=manual