Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v1.12.4 #1778

Merged
merged 3 commits into from
Sep 2, 2022
Merged

v1.12.4 #1778

merged 3 commits into from
Sep 2, 2022

Commits on Sep 2, 2022

  1. gracefully handle analytics error (#1774) 

    Throw error from not having `ytag` script tag for conversion tracking opt in would prevent a search fired on load. This is an aggressive behavior as analytics shouldn't affect search behavior. This pr updated the two throw error into console error instead.

Same as #1771 but without acceptance tests changes

TEST=manual

Added `ANSWERS.setConversionsOptIn(true);` to a local index page with Answers setup. see that the previously uncaught throw error is now a console error and a search on load is no longer blocked.

<img width="1786" alt="Screen Shot 2022-08-31 at 8 36 25 AM" src="https://user-images.githubusercontent.com/36055303/187679764-b5c9a6e6-bf12-4467-a42b-66fb3052846d.png">
    @yen-tt
    yen-tt authored and Yen Truong committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    6640f33 View commit details
    Browse the repository at this point in the history

  2. version bump

    Yen Truong committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    8b42e2d View commit details
    Browse the repository at this point in the history

  3. update third-party-notices

    Yen Truong committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    5856182 View commit details
    Browse the repository at this point in the history