update canonicalizeLocale to handle 中文(chinese) #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
J=SLAP-1526 TEST=auto unit tests
oshi97
commented
Aug 18, 2021
|
was testing in the theme and this doesn't handle |
cea2aj
reviewed
Aug 18, 2021
cea2aj
approved these changes
Aug 18, 2021
cea2aj
reviewed
Aug 18, 2021
cea2aj
reviewed
Aug 18, 2021
| const numSections = localeCodeSections.length; | ||
| if (numSections === 1) { | ||
| return {}; | ||
| } else if (numSections === 2 && language === 'zh') { |
There was a problem hiding this comment.
Should we handle codes such as: zh_CH? Currently it would treat CH as a modifier when really its a region
There was a problem hiding this comment.
yeah I missed this case
Merged
oshi97
added a commit
that referenced
this pull request
Aug 24, 2021
* Do not run the babel helper in Development Mode. (#224) (#225) * Use npmlog for logging with colors (#228) * Add Jambo build validation hook (#229) * Added acceptance testing framework + tests * add --globs param to `jambo extract-translations` (#233) * Pass partials to templatedatavalidator (#237) * `jambo upgrade` no longer deletes the themes folder if there is an error when git checkout-ing the new branch (#235) * Update canonicalizeLocale to handle 中文(chinese) (#239)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
J=SLAP-1526
TEST=auto,manual
unit tests
ran build with zh-hans-ch in locale config, saw that the generated source code used the correct locale in the page
tried building a page with a locale with >3 sections, got a jambo warning but build continued without changing the locale