Do not run the babel helper in Development Mode.
#224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds a check to the `babel` helper to see if we are currently in the Development Mode. If so, the enclosed source code is not run through Babel, it is returned verbatim. This is a preview optimization, since the Babel-ification is a relatively slow operation. It's not necessary for preview either, assuming devs are not previewing their changes in IE11. J=SLAP-1312 TEST=manual Ensured that when in Development mode, the helper was a simple pass-through. In Production mode, the enclosed code was Babel-ified.
|
If someone does want to test the page in IE11, then they will need to publish to staging, correct? |
cea2aj
approved these changes
May 19, 2021
Correctomundo |
tmeyer2115
added a commit
that referenced
this pull request
May 19, 2021
This PR adds a check to the `babel` helper to see if we are currently in the Development Mode. If so, the enclosed source code is not run through Babel, it is returned verbatim. This is a preview optimization, since the Babel-ification is a relatively slow operation. It's not necessary for preview either, assuming devs are not previewing their changes in IE11. J=SLAP-1312 TEST=manual Ensured that when in Development mode, the helper was a simple pass-through. In Production mode, the enclosed code was Babel-ified.
Merged
oshi97
added a commit
that referenced
this pull request
Aug 24, 2021
* Do not run the babel helper in Development Mode. (#224) (#225) * Use npmlog for logging with colors (#228) * Add Jambo build validation hook (#229) * Added acceptance testing framework + tests * add --globs param to `jambo extract-translations` (#233) * Pass partials to templatedatavalidator (#237) * `jambo upgrade` no longer deletes the themes folder if there is an error when git checkout-ing the new branch (#235) * Update canonicalizeLocale to handle 中文(chinese) (#239)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a check to the
babelhelper to see if we are currently in the Development Mode. Ifso, the enclosed source code is not run through Babel, it is returned verbatim. This is a preview
optimization, since the Babel-ification is a relatively slow operation. It's not necessary for
preview either, assuming devs are not previewing their changes in IE11.
J=SLAP-1312
TEST=manual
Ensured that when in Development mode, the helper was a simple pass-through. In Production mode,
the enclosed code was Babel-ified.