Changed upgrade functionality #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…les when it errors out. J=SLAP-1308 TEST=manual/automatic Tested by running jambo upgrade on the hitchhiker theme and making sure that upgrade ran unchanged when no error occurs. Also ran with an artificial error to make sure that theme files are reverted correctly. Created acceptance test for themeupgrader that checks to make sure that when jambo upgrade errors out, the test-theme remains unchanged.
cea2aj
reviewed
Jun 28, 2021
cea2aj
reviewed
Jun 28, 2021
cea2aj
reviewed
Jun 28, 2021
cea2aj
reviewed
Jun 28, 2021
Merged
oshi97
added a commit
that referenced
this pull request
Aug 24, 2021
* Do not run the babel helper in Development Mode. (#224) (#225) * Use npmlog for logging with colors (#228) * Add Jambo build validation hook (#229) * Added acceptance testing framework + tests * add --globs param to `jambo extract-translations` (#233) * Pass partials to templatedatavalidator (#237) * `jambo upgrade` no longer deletes the themes folder if there is an error when git checkout-ing the new branch (#235) * Update canonicalizeLocale to handle 中文(chinese) (#239)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed upgrade functionality, so that now it reverts to old theme files when it errors out.
J=SLAP-1308
TEST=manual/automatic
Tested by running jambo upgrade on the hitchhiker theme and making sure that upgrade ran unchanged when no error occurs. Also ran with an artificial error to make sure that theme files are reverted correctly.
Created acceptance test for themeupgrader that checks to make sure that when jambo upgrade errors out, the test-theme remains unchanged.