Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a dune file and a new package extlib_wrapped #54

Closed
wants to merge 2 commits into from
Closed

Add a dune file and a new package extlib_wrapped #54

wants to merge 2 commits into from

Conversation

jorisgio
Copy link

This intends to solve same issue as #53

@olafhering
Copy link

I think the changes from dune-universe/ocaml-extlib@4e178dc to build with dune are more complete. Still, they lack support for the dune runtest target.

@ygrek what is your opinion regarding building the entire thing with dune?

@avery-laird
Copy link

This still seems to be a problem with dune utop:

[<me>@<me> js2sil]$ dune utop
File "<home>/.opam/ocaml-variants.4.07.1+flambda/lib/base64/base64.cma(Base64)", line 1:
Warning 31: files <home>/.opam/ocaml-variants.4.07.1+flambda/lib/base64/base64.cma(Base64) and <home>/.opam/ocaml-variants.4.07.1+flambda/lib/extlib/extLib.cma(Base64) both define a module named Base64

@ygrek
Copy link
Owner

ygrek commented Apr 24, 2020

@ygrek what is your opinion regarding building the entire thing with dune?

I am ok to add it in parallel to Makefile.

@ygrek ygrek self-assigned this Apr 24, 2020
@Et7f3
Copy link

Et7f3 commented Sep 12, 2020

What is the state of this pr ? Can I help ?

Et7f3
Et7f3 reviewed Sep 12, 2020
View reviewed changes
.merlin
@@ -1,4 +1,22 @@
EXCLUDE_QUERY_DIR
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be ignored by git

dune
(action
(run ./genconfig.exe)))

(copy_files src/*.ml*)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can declare this dune stanza in src folder and avoid copy.

dune
Comment on lines +22 to +23
(name extlib)
(public_name extlib_wrapped)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this breakage ? if named extLib then user could still consume without noticing the switch to dune.

Suggested change
(name extlib)
(public_name extlib_wrapped)
(name extLib)
(public_name extlib)

extlib_wrapped.opam
]
build: ["dune" "build" "-p" name]
depends: [
"ocaml"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dune is obviously omitted 👀 their is dune_generate_opam_file if you want.

flags.sexp
@@ -0,0 +1 @@
(-w -3-6-9-27-32-33-39-50 -no-strict-sequence)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't be committed

This was referenced May 4, 2022
Open
Open
@ygrek
Copy link
Owner

ygrek commented Jul 19, 2022

Superceded by #59, thanks! After switching to dune will make a breaking change with version bump to the wrapped library.

@ygrek ygrek closed this Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Et7f3 Et7f3 Et7f3 left review comments

Assignees

@ygrek ygrek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jorisgio @olafhering @avery-laird @ygrek @Et7f3