You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Legend information is created in the assign functions called by components.assign_visual_mapping and it is attached to the ggplot object to create
the legend dictionary.
And no ggplot object would be passed, instead assign_visual_mapping would return the legend, so each layer would be able to control the legend, #211. The changes also include doing away with the matplotlib API names, this has cascading effects, https://github.com/yhat/ggplot/blob/master/ggplot/geoms/geom.py#L74. Changes would also be made to handle the fill mapping. Keeping the column name would allow for smarter legends later on, #89.
Legend information is created in the assign functions called by
components.assign_visual_mapping
and it is attached to the ggplot object to createthe legend dictionary.
The refactoring would have the legend modified to
And no ggplot object would be passed, instead
assign_visual_mapping
would return the legend, so each layer would be able to control the legend, #211. The changes also include doing away with the matplotlib API names, this has cascading effects, https://github.com/yhat/ggplot/blob/master/ggplot/geoms/geom.py#L74. Changes would also be made to handle the fill mapping. Keeping the column name would allow for smarter legends later on, #89.This is issue is in someway a blocker for #266.
The text was updated successfully, but these errors were encountered: