New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reference constructor #53

Closed

SamMousa opened this issue Oct 25, 2018 · 1 comment

Labels

status:ready for adoption type:enhancement

Contributor

SamMousa commented Oct 25, 2018

Currently Reference has 2 constructors, 1 static one and 1 non-static one.

I imagine the static one was added mostly for syntactic sugar:

$container->get(Reference::to('someService')); 
// vs
$container->get(new Reference('someService'));

If we decide to support this syntax then in my opinion we should make the __construct() constructor private.

The text was updated successfully, but these errors were encountered:

samdark added type:enhancement status:ready for adoption labels

Contributor Author

SamMousa commented Nov 2, 2018

Implemented by #57

SamMousa closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment