Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version of pjax #55

Closed
armpogart opened this issue May 25, 2017 · 5 comments
Closed

New version of pjax #55

armpogart opened this issue May 25, 2017 · 5 comments
Assignees
Milestone

Comments

@armpogart
Copy link

Original jquery-pjax was updated recently to new version with some minor backward incompatibilities, will you accept pull request to this repo with those changes?

@samdark
Copy link
Member

samdark commented May 26, 2017

Depends on what these incompatibilities are and if they'll break existing projects. Also, we have our own changes to the code.

@armpogart
Copy link
Author

armpogart commented Jun 21, 2017

First full CHANGELOG after the latest merge from upstream to this repo (by versions):

1.9.6

  • Change internal cache struct to fix restoring mixed containers.
  • Avoid tackling on extra # on URLs in Safari.
  • Fix stripping internal query params to avoid touching & and ? in components other than query string.

2.0.0

  • This release brings jQuery 3.x compatibility.
  • The value of container parameter to pjax functions should be a string selector, and not a jQuery object anymore. (backwards incompatible)
  • The value of container parameter cannot be a DOM node with an ID anymore. (backwards incompatible)
  • The call signature $("#main").pjax("a") is not supported anymore because the container selector #main cannot be inferred from the context of the $.fn.pjax() call. To fix this, pass the container selector explicitly: $("#main").pjax("a", "#main") (backwards incompatible)

2.0.1 (I suppose some of these changes can also be backwards incompatible with the old version)

  • Fix blurring current active element within pjax container
  • Remove extra & after stripping internal query params
  • Handle documents with no or empty tag
  • Fix npm warnings about package.json
  • Add eslint to project

I haven't checked which backwards incompatible changes would also be backwards incompatible here, as this fork is mainly used through `Yii::pjax`` wrapper which can overcome some backwards incompatibilities I guess. But the jQuery 3.x compatibility is very important in my opinion and original repo is again under constant development now (more or less), so it would be helpful to incorporate upstream changes.

May I try to prepare PR? (отталкиваясь из того, что не все изменения сломают эту версию, так как она не используется отдельно, а через Yii, и можно сохранить совместимость через PHP код)

@samdark
Copy link
Member

samdark commented Jun 21, 2017

Yes, you can prepare a pull request but then you should be careful since we have our own changes in the code.

@samdark
Copy link
Member

samdark commented Sep 25, 2017

#59

@SilverFire
Copy link
Member

Resolved by 047a0b0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants