-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New version of pjax #55
Comments
Depends on what these incompatibilities are and if they'll break existing projects. Also, we have our own changes to the code. |
First full CHANGELOG after the latest merge from upstream to this repo (by versions): 1.9.6
2.0.0
2.0.1 (I suppose some of these changes can also be backwards incompatible with the old version)
I haven't checked which backwards incompatible changes would also be backwards incompatible here, as this fork is mainly used through `Yii::pjax`` wrapper which can overcome some backwards incompatibilities I guess. But the jQuery 3.x compatibility is very important in my opinion and original repo is again under constant development now (more or less), so it would be helpful to incorporate upstream changes. May I try to prepare PR? (отталкиваясь из того, что не все изменения сломают эту версию, так как она не используется отдельно, а через Yii, и можно сохранить совместимость через PHP код) |
Yes, you can prepare a pull request but then you should be careful since we have our own changes in the code. |
Resolved by 047a0b0 |
Original jquery-pjax was updated recently to new version with some minor backward incompatibilities, will you accept pull request to this repo with those changes?
The text was updated successfully, but these errors were encountered: