Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs/guide/topics.i18n.txt #1305

Merged
merged 1 commit into from
Aug 29, 2012
Merged

Update docs/guide/topics.i18n.txt #1305

merged 1 commit into from
Aug 29, 2012

Conversation

brettz9
Copy link
Contributor

@brettz9 brettz9 commented Aug 29, 2012

Some minor grammar/clean-up/clarity fixes

Some minor grammar/clean-up/clarity fixes
@ghost ghost assigned cebe Aug 29, 2012
cebe added a commit that referenced this pull request Aug 29, 2012
Update docs/guide/topics.i18n.txt

[ci skip]
@cebe cebe merged commit f3f2786 into yiisoft:master Aug 29, 2012
@cebe
Copy link
Member

cebe commented Aug 29, 2012

Thanks!

@@ -24,14 +24,14 @@ user interface. It is usually identified by an ID consisting of a language
ID and a region ID. For example, the ID `en_US` stands for the locale of
English and United States. For consistency, all locale IDs in Yii are
canonicalized to the format of `LanguageID` or `LanguageID_RegionID`
in lower case (e.g. `en`, `en_us`).
in lower case (e.g., `en`, `en_us`).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is just the standard convention

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, overlooked that. fixed.

@samdark
Copy link
Member

samdark commented Aug 29, 2012

Thanks for this contribution. It really makes Yii docs better.

@brettz9
Copy link
Contributor Author

brettz9 commented Aug 29, 2012

My pleasure---Yii is really awesome, so deserves some attention on its already very readable docs! I hope someone will port Yii to Server-side JavaScript though, as I think that will be the future.

cebe added a commit that referenced this pull request Aug 29, 2012
@brettz9 brettz9 deleted the patch-1 branch January 18, 2013 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants