fix #3589 using the proposed tactic. #3590
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ON::decode() is not so sophisticated that it checks the legality of the Unicode characters in the Unicode strings in the input: some illegal stuff *may* slip through that way.)
|
As per my own comment in #3589: first tactic to solve is pass extra tracking flag parameter by reference and check when appropriate. I only check at the end as I don't mind that the parse possibly continues after an error; cycles are not possible, so it doesn't matter and meanwhile means I don't load a legal-data parse with superfluous checks in the recursive decode path. |
|
Won't be fixed in 1.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Aside: Note that the CJSON::decode() is still not so sophisticated that it checks the legality of the Unicode characters in the Unicode strings in the input: some illegal stuff may slip through that way. For when you feel like being extra nasty...)