viaTable relation does not unlink same records which it selects

[ghost]

Hi guys, I have relation 1:n via pivot table declared as

return $this->hasMany(User::className(), ['id' => 'user_id'])
                    ->viaTable('edu_course_users', ['course_id' => 'id'], function (ActiveQuery $relation) {
                        $relation->andWhere('role = :role', [':role' => EduCourseUsers::ROLE_TEACHER]);
                    });

The select query which it makes is OK

SELECT * FROM `edu_course_users` WHERE (role = 'teacher') AND (`course_id`=1)

But the delete query, produced when I am executing

$this->unlinkAll('teachers', true)

is not OK

DELETE FROM `edu_course_users` WHERE `course_id`=1

It does not contain the additional where clause, which is present in the SELECT query.

[padlyuck]

Sorry for duplicates

[undefinedor]

I write a test to verify this issue. but there seems to be no problem. The issue should close.

[undefinedor]

// ActiveRecordTest.php
    public function testUnlinkAllOnConditionViaTable()
    {
        /** @var Order $orderClass */
        $orderClass = $this->getOrderClass();
        /** @var Item $itemClass */
        $itemClass = $this->getItemClass();

        // Ensure there are three items with category_id = 2 in the Items table
        $itemsCount = $itemClass::find()->where(['category_id' => 2])->count();
        $this->assertEquals(3, $itemsCount);

        $orderQuery = $orderClass::find()->with('limitedItems')->where(['id' => 2]);
        // Ensure that limitedItems relation returns only one item
        // (category_id = 2 and id in (4, 5))
        $category = $orderQuery->one();
        $this->assertCount(2, $category->limitedItems);

        // Unlink all items in the limitedItems relation
        $category->unlinkAll('limitedItems', true);

        // Call $orderQuery again to ensure that links are removed
        $this->assertCount(0, $orderQuery->one()->limitedItems);

        // Make sure that only links were removed, the items were not removed
        $this->assertEquals(3, $itemClass::find()->where(['category_id' => 2])->count());
    }

[undefinedor]

The test code has covered this issue.

[samdark]

Interesting. Thanks for doing that.

1. We need the test in our test set if it checks something we haven't checked before.
2. How does it relate to unlink and link should also use the via on conditions of the relation #17174?

[samdark]

Seems it was fixed by #12213. Thanks, @undefinedor