Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings system to save variables #14

Closed
DayibBaba opened this issue Aug 27, 2023 · 5 comments
Closed

Settings system to save variables #14

DayibBaba opened this issue Aug 27, 2023 · 5 comments
Labels
prio This issue takes precedence over others

Comments

@DayibBaba
Copy link
Contributor

No description provided.

@MarkEcza
Copy link
Contributor

std::map<string, std::any> :trollface:

@DayibBaba
Copy link
Contributor Author

I could just port over the one from YimMenu as it works just great.

@Yimura
Copy link
Member

Yimura commented Aug 28, 2023

The main downside of using that one is that changing one single line requires a full recompile of the menu.

It would be good to take a look at separating settings to their specific features.

@DayibBaba
Copy link
Contributor Author

The main downside of using that one is that changing one single line requires a full recompile of the menu.

It would be good to take a look at separating settings to their specific features.

Wouldn't having saving structs have their own file instead of hosting all in the settings.hpp file already suffice?

@MarkEcza
Copy link
Contributor

What about a dynamic container? It would definitely impact performance to some degree maybe noticeable maybe not but it would be very easy to save, load and edit.

@DayibBaba DayibBaba added the prio This issue takes precedence over others label Sep 10, 2023
@DayibBaba DayibBaba linked a pull request Sep 23, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prio This issue takes precedence over others
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants