Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up associations #3

Merged
merged 7 commits into from
Sep 6, 2023
Merged

Set up associations #3

merged 7 commits into from
Sep 6, 2023

Conversation

yin-ka
Copy link
Owner

@yin-ka yin-ka commented Sep 6, 2023

In this pull request, I achieved the following objectives:

  • Created classes and objects in Ruby.
  • Employed encapsulation and inheritance concepts in Ruby.
  • Executed a program through the command line.
  • Demonstrated the use of composition.
  • Established associations between various classes and objects.

Copy link

@frank1738 frank1738 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @yin-ka ,

You've aced it! Let's cut to the chase and merge it :shipit:
Congratulations! 🎉

Highlights

🌟 Great job! Your documentation is on point and super professional! 📝✨
👍 Your work on setting up the associations is spot on! Keep up the awesome work! 🚀👏

Optional suggestions

N/A

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@yin-ka yin-ka merged commit 666ef1d into dev Sep 6, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants