Switch to electron-builder #165
Conversation
Still some fields that need populating to get all the features, but this should suffice for a simple build for now.
This is NOT A GOOD THING, I just don't have the original high-res asset so it's a temporary hack. Hopefully I can get a real icns soon.
Nobody uses AppImage anyway...
package.json
Outdated
| ], | ||
| "files": [ | ||
| "**/*", | ||
| "!(build.js|docs|tests?|examples|.c9|scss|^/node_modules/(moment|(octicons|sigma)/(plugins|lib|src|build/font)))($|/)" |
There was a problem hiding this comment.
Ideally we can now split this massive rule up into a series of smaller rules, since build.files supports that. I just didn't wanna mess with it until I was sure it was correct first.
There was a problem hiding this comment.
Looking at the documentation, it seems like electron-builder isn't using Regex, but glob patterns. I'll look into it...
|
Thank you so much! I'll look over it after my exams. |
package.json
Outdated
| }, | ||
| "win": { | ||
| "iconUrl": "https://raw.githubusercontent.com/yishn/sabaki/master/data/icon.ico", | ||
| "target": ["msi"] |
There was a problem hiding this comment.
Is there a msi target for Windows? It doesn't work on my machine and I couldn't find the target in the documentation. Maybe we can just provide a 7z or use NSIS?
package.json
Outdated
| { | ||
| "ext": "sgf", | ||
| "name": "SGF" | ||
| } |
There was a problem hiding this comment.
Does this mean build/extra-info.plist is redundant now?
package.json
Outdated
| ], | ||
| "files": [ | ||
| "**/*", | ||
| "!(build.js|docs|tests?|examples|.c9|scss|^/node_modules/(moment|(octicons|sigma)/(plugins|lib|src|build/font)))($|/)" |
There was a problem hiding this comment.
Looking at the documentation, it seems like electron-builder isn't using Regex, but glob patterns. I'll look into it...
Conflicts: data/icon.icns data/icon.ico
This addresses #158.
Electron-packager generates standalone packages, while electron-builder can generate platform-specific installers. There are several benefits of electron-builder, including:
package.jsonin my opinion. There's a separate config section instead of passing in a bunch of args to each platform'sbuildstep.Some major things I need help with:
I've tested on all three major platforms on my machines, and everything seems to work well, as far as I can tell. Let me know if you prefer these commits squashed!