Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure to parse CVS: date -0600 timezone #44

Closed
GoogleCodeExporter opened this issue May 2, 2015 · 3 comments
Closed

Failure to parse CVS: date -0600 timezone #44

GoogleCodeExporter opened this issue May 2, 2015 · 3 comments

Comments

@GoogleCodeExporter
Copy link

What steps will reproduce the problem?
1.  My CVS log generated with the cvs-exp.pl file have a negative timezone
offset (-0600)
2.  gource unceremoniously exits

What is the expected output? What do you see instead?
Expect proper performance, instead get exception that log can not be read.


What version of the product are you using? On what operating system?
0.24 on MacOSX

Please provide any additional information below.

Here is the proper REGEXP that belongs on line 22 of cvs-exp.cpp

Regex cvsexp_date_regex("^\\(date: ([0-9]{4})[-/]([0-9]{2})[-/]([0-9]{2})
([0-9]{2}):([0-9]{2}):([0-9]{2})(?: \\[+--][0-9]{4})?;(.+)$");


Note that + and - can be handled in the timezone offset.

This will parse entries like:

(date: 2000-01-24 17:01:45 -0600;  author: martink;  state: Exp;)         


Original issue reported on code.google.com by blezek@gmail.com on 17 Feb 2010 at 6:41

@GoogleCodeExporter
Copy link
Author

Sorry, the regexp didn't do the job.  Have to dig in a bit more...

Original comment by blezek@gmail.com on 17 Feb 2010 at 6:45

@GoogleCodeExporter
Copy link
Author

[deleted comment]

@GoogleCodeExporter
Copy link
Author

Hi.

Thanks for the report. I've changed it to:

Regex cvsexp_date_regex("\\(date: ([0-9]{4})[-/]([0-9]{2})[-/]([0-9]{2})
([0-9]{2}):([0-9]{2}):([0-9]{2})(?: [+-][0-9]{4})?;(.+)$");

Original comment by acaudw...@gmail.com on 17 Feb 2010 at 8:58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant