Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uses two versions of mesh_AABB header and source file each, at the same time (!) - please rename at least and clarify #88

Closed
Mathias-Fuchs opened this issue Feb 16, 2022 · 1 comment

Comments

@Mathias-Fuchs
Copy link

$ find -name mesh_AABB.h
./extern/geogram/src/lib/geogram/mesh/mesh_AABB.h
./src/tetwild/geogram/mesh_AABB.h
$ find -name mesh_AABB.cpp
./extern/geogram/src/lib/geogram/mesh/mesh_AABB.cpp
./src/tetwild/geogram/mesh_AABB.cpp

Both mesh_AABB.h seem to be almost but not exactly the same. I am very sorry to be so direct, but this is quite a whacky way to write software and causes worries for everyone who wants to work with the code.

@Yixin-Hu
Copy link
Owner

Hi,

./extern/geogram/src/lib/geogram/mesh/mesh_AABB.h/cpp is the code inside the dependent library Geogram. ./src/tetwild/geogram/mesh_AABB.h/cpp is the code we reimplemented recycling the most part of ./extern/geogram/src/lib/geogram/mesh/mesh_AABB.h/cpp with small (but important) changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants