Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line Search throws increasing search direction exception #15

Closed
JonasZehn opened this issue Oct 28, 2020 · 1 comment · Fixed by #25
Closed

Line Search throws increasing search direction exception #15

JonasZehn opened this issue Oct 28, 2020 · 1 comment · Fixed by #25

Comments

@JonasZehn
Copy link

Hi,

I was testing the LBFGSB code with the default LineSearchMoreThuente and it throws with throw std::logic_error("the moving direction does not decrease the objective function value") (on line 198 in LineSearchMoreThuente.h). I think it is because dg_init is computed using the gradient instead of the projected gradient? I attached the test case.

main.txt

@JonasZehn JonasZehn changed the title Line Search erroneously throws increasing search direction exception Line Search throws increasing search direction exception Oct 28, 2020
@JonasZehn
Copy link
Author

Ok, the reason might be a different one than I suggested, the search direction after subspace_minimize just seems to be ascending and it doesn't have to do anything with the gradient being projected or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant