Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dg_hi set but never used warning in LBFGSpp/LineSearchNocedalWright.h ? #35

Closed
WhateverLiu opened this issue Jun 6, 2023 · 1 comment
Closed

dg_hi set but never used warning in LBFGSpp/LineSearchNocedalWright.h ? #35

WhateverLiu opened this issue Jun 6, 2023 · 1 comment

Comments

@WhateverLiu
Copy link

By inspecting the code it seems indeed dg_hi only appears on the left side of the assignments in LineSearchNocedalWright.h?
@WhateverLiu WhateverLiu changed the title dg_hi set but never used warning in LBFGSpp/LineSearchNocedalWright.h ? dg_hi set but never used warning in LBFGSpp/LineSearchNocedalWright.h ? Jun 6, 2023
@yixuan
Copy link
Owner

yixuan commented Jul 12, 2023

Good catch. It has been fixed in 0a32ccb. Thanks!

@yixuan yixuan closed this as completed Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yixuan @WhateverLiu