Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

monaco-editor collaboration seems to be broken with y-js 13.3.0 (latest), works fine with 13.0 #41

Closed
stefan-egorov opened this issue Aug 3, 2020 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@stefan-egorov
Copy link

Describe the bug:
When using monaco-demo with latest y-js version, user's cursors are incorrectly updated.
monaco-bug
Things get really off with both typing at the same time.

To Reproduce

  1. clone the repo. cd monanco
  2. bump yjs to latest in package.json -> ~13.3.0
  3. npm install
  4. npm start
  5. run yjs demo

Expected behavior
It should work similar to yjs version 13.0.0 🤔

Environment Information

  • Browser - Firefox 79.0 | Chrome 84.0 | Node.js v12.17.0
  • Yjs version 13.3.0

PS: The library looks really neat!

@stefan-egorov stefan-egorov added the bug Something isn't working label Aug 3, 2020
@stefan-egorov
Copy link
Author

Hey @dmonad, to me this looks like a bug in awareness protocol. Can you confirm? Or am I missing something?

@dmonad
Copy link
Member

dmonad commented Aug 7, 2020

Hey @stefan-egorov ,

thanks for reporting. I fixed the problem in y-monaco@0.1.0. Also see yjs/y-monaco#2

@dmonad dmonad closed this as completed Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants