Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox v89 Support #30

Open
ghost opened this issue Jun 7, 2021 · 3 comments
Open

Firefox v89 Support #30

ghost opened this issue Jun 7, 2021 · 3 comments
Labels
bugzilla Waiting for a firefox to be resolved

Comments

@ghost
Copy link

ghost commented Jun 7, 2021

Firefox v89 introduced a new UI and a new default theme supported by Firefox fresh out of the box. Envify fails to reset its environment color now when you cycle to another tab.

It would also be nice to have the colors reset back to the default theme applied, rather than to white when not on a set domain, as that means once you've visited a site with a programmed color, you never see your default theme again until you close and open again.

While I'm here, might I suggest themes that can be applied, rather than just a static color when on certain URLs?

Love the plugin. Keep up the awesome work.
Fen.

@ylecuyer
Copy link
Owner

ylecuyer commented Jun 7, 2021

Envify fails to reset its environment color now when you cycle to another tab.

Could you make a screencast to be sure we are on the same page here?
It looks like a known bug of firefox, you should try disabling the extension when choosing your them then enable it back.

While I'm here, might I suggest themes that can be applied, rather than just a static color when on certain URLs?

This is not possible afaik the API only allows to change colors

@jgato
Copy link

jgato commented Jun 9, 2021

Could you make a screencast to be sure we are on the same page here?
It looks like a known bug of firefox, you should try disabling the extension when choosing your them then enable it back.

This workaround does not work. I have any any default tab with the Firefox selected theme:

image

So now I change to a tab controlled by envify, like whatsapp, that in my case, green'ify my firefox:

image

back to the initial tab (not controlled by envify), everything still green'ify instead of default firefox theme:

image

@ylecuyer
Copy link
Owner

This is a bug in the firefox API for themes not whitelisting moz-extension:// uri for resources

Screenshot_2021-06-10_13-31-15

I have opened a bug report https://bugzilla.mozilla.org/show_bug.cgi?id=1715753 you can follow, meanwhile there is nothing that can be done from the extension side, it will work only with color only themes (like default theme or dark theme)

@ylecuyer ylecuyer added the bugzilla Waiting for a firefox to be resolved label Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugzilla Waiting for a firefox to be resolved
Projects
None yet
Development

No branches or pull requests

2 participants