Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chinese Translation #37

Closed
ylexus opened this issue Jun 4, 2020 · 6 comments
Closed

Chinese Translation #37

ylexus opened this issue Jun 4, 2020 · 6 comments

Comments

@ylexus
Copy link
Owner

ylexus commented Jun 4, 2020

To help with translation, please have a look at this file: https://github.com/ylexus/jiotty-photos-uploader/blob/master/src/main/resources/i18n/Resources.properties. It contains all the phrases needed by the app. The file is in the format:

key=phrase

There are also some clarifying comments in the file that start with '#' - these explain some context for the key that follows, but do not need to be translated.

@axylee, there are two options:

  1. if you are familiar with git and GitHub, you could just create two copies of this file in same directory and submit a pull request.
  2. if you are not familiar with git, please copy-paste the contents of the file above here twice in two different comments and in each comment replace the English text after the "=" with the corresponding Chinese phrase?

Thanks again for agreeing to help!

@axylee
Copy link
Contributor

axylee commented Jun 5, 2020

I had add one file in i18n and pull request , please have a look , and let me know if I am do wring .

@axylee
Copy link
Contributor

axylee commented Jun 5, 2020

Created 9 files , and pull request , not sure if the file name format is work for this code , please verify , thank you.
-----Chinese Traditional-----
Resources_zh_TW.properties
Resources_zh-CHT.properties
Resources_zh-HK.properties
Resources_zh-HANT.properties
Resources_zh-MO.properties

-----Chinese Simplified-----
Resources_zh-CHS.properties
Resources_zh-CN.properties
Resources_zh-HANS.properties
Resources_zh-SG.properties

@ylexus
Copy link
Owner Author

ylexus commented Jun 5, 2020

Thanks, I did not expect you to create pull requests - excellent! Even better if it was one pull request for all 9 files instead of 9 different ones :) But that's ok, next time maybe. I'll add comments to only some of them.

ylexus added a commit that referenced this issue Jun 8, 2020
#37 Create Resources_zh_TW.properties
ylexus added a commit that referenced this issue Jun 8, 2020
#37 Create Resources_zh_CHT.properties
ylexus added a commit that referenced this issue Jun 8, 2020
#37 Create Resources_zh_HK.properties
ylexus added a commit that referenced this issue Jun 8, 2020
#37 Create Resources_zh_HANT.properties
ylexus added a commit that referenced this issue Jun 8, 2020
#37 Create Resources_zh_MO.properties
ylexus added a commit that referenced this issue Jun 8, 2020
#37 Create Resources_zh_CHS.properties
ylexus added a commit that referenced this issue Jun 8, 2020
#37 Create Resources_zh_CN.properties
ylexus added a commit that referenced this issue Jun 8, 2020
#37 Create Resources_zh_HANS.properties
ylexus added a commit that referenced this issue Jun 8, 2020
#37 Create Resources_zh_SG.properties
@ylexus
Copy link
Owner Author

ylexus commented Jun 8, 2020

Thanks, all merged, will be in the next release. Huge thanks for your help!

@ylexus ylexus closed this as completed Jun 8, 2020
@ylexus
Copy link
Owner Author

ylexus commented Jun 12, 2020

@axylee, 1.2.0 is now available with your translation and a few bugfixes around the stop button. Thanks for your contribution!

@axylee
Copy link
Contributor

axylee commented Jun 15, 2020

Both Traditional and simplified Chinese are display fine ! and upload seems more smooth on 1.2.0 . If there is additional feature need to test or translate in the future, please feel free to let me know .

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants